Skip to content

[Chore](memory) add jemalloc_hook to make jemalloc control malloc #54547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 1 commit into from
Aug 11, 2025
Merged

[Chore](memory) add jemalloc_hook to make jemalloc control malloc #54547

BiteTheDDDDt merged 1 commit into from
Aug 11, 2025
+96 −14

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Aug 11, 2025 •
edited
Loading

What problem does this PR solve?

In #53794 and #54028, we remove jemalloc_hook, but I found that without a jemalloc hook would cause doris to allocate memory not to apply jemalloc, but instead use glibc's malloc, so I added it back.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Aug 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Aug 11, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 11, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.45% (22485/27605)
Line Coverage 74.11% (232929/314301)
Region Coverage 61.49% (193881/315310)
Branch Coverage 65.51% (83681/127740)

@BiteTheDDDDt BiteTheDDDDt merged commit 852c306 into apache:master Aug 11, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w41ter w41ter w41ter approved these changes

@yiguolei yiguolei yiguolei approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BiteTheDDDDt @Thearas @hello-stephen @w41ter @yiguolei